Skip to content

feat(rust/signed-doc): CatalystSignedDocument validator basic structure #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Feb 3, 2025
Merged

feat(rust/signed-doc): CatalystSignedDocument validator basic structure #196

merged 29 commits into from
Feb 3, 2025

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Feb 3, 2025

Description

  • Added an initial implementation of the validator::validate function.
  • Added DocumentType enum.
  • Refactored, removed redundant types.

Related Issue(s)

Closes input-output-hk/catalyst-voices#1753

saibatizoku and others added 27 commits January 27, 2025 12:25
@saibatizoku
fix(rust/signed-doc): add content type validation
4e5ff19
@saibatizoku
fix(rust/signed-doc): content encoding field is optional
15741c6
@saibatizoku
fix(rust/signed-doc): add 'half' feature from minicbor crate
3d34e47
@saibatizoku
wip(rust/signed_doc): implement verification method
3a66559 
* verify signatures with public (verification) key
* todo: verify UUIDs
@saibatizoku
fix(rust/signed-doc): fix content-type verification
70440b5
@saibatizoku
wip(rust/signed_doc): implement verification method
bd4561d 
* verify doc type, id and ver
@saibatizoku
wip(rust/signed_doc): implement verification method
2392ed5 
* verify extra fields
@saibatizoku
Merge branch 'main' into feat/doc-signing-logic
dd60045
@saibatizoku
feat(rust/signed-doc): add signatures to Catalyst Signed Document
22c46f0
@saibatizoku
fix(rust/signed-doc): refactor cli tool to sign
0f85057
@saibatizoku
fix(rust/signed-doc): add verify command to cli tool
ee0657c
@saibatizoku
fix(rust/catalyst-types): refactor sigining logic into builder
262b1ad
@saibatizoku
Merge branch 'main' into feat/doc-signing-logic
a1c11ea
@saibatizoku
chore(docs): fix spelling
56b0509
@saibatizoku
fix(rust/signed-doc): cleanup
70cae9f
@Mr-Leshiy
fix content validation, add unit test
0329541
@Mr-Leshiy
remove clippy
3d1b044
@Mr-Leshiy
remove redundant types
5b20cfd
@Mr-Leshiy
fix
5682dd5
@Mr-Leshiy
Merge branch 'feat/doc-signing-logic' into feat/cat-sign-doc-validator
d48d27b
@Mr-Leshiy
add DocumentType
84b891e
@Mr-Leshiy
wip
e199d8e
@Mr-Leshiy
add validator module
53deef7
@Mr-Leshiy
add Proposal Document type
830e4ef
@Mr-Leshiy
wip
1f02d57
@Mr-Leshiy
wip
9c40793
@Mr-Leshiy
Merge branch 'main' into feat/cat-sign-doc-validator
c303489
@Mr-Leshiy Mr-Leshiy changed the title feat(rust/signed-doc): feat(rust/signed-doc): CatalystSignedDocument validator basic structure Feb 3, 2025
@Mr-Leshiy Mr-Leshiy self-assigned this Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@Mr-Leshiy Mr-Leshiy requested a review from saibatizoku February 3, 2025 16:56
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review February 3, 2025 16:56
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

saibatizoku
saibatizoku previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to get validation code started.

@saibatizoku saibatizoku enabled auto-merge (squash) February 3, 2025 18:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@minikin minikin self-requested a review February 3, 2025 19:56
@saibatizoku saibatizoku merged commit 7080c53 into main Feb 3, 2025
20 of 22 checks passed
@saibatizoku saibatizoku deleted the feat/cat-sign-doc-validator branch February 3, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@minikin minikin minikin approved these changes

Assignees

@Mr-Leshiy Mr-Leshiy

Labels

review me PR is ready for review

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CatalystSignedDocument validator basic structure

4 participants

@Mr-Leshiy @saibatizoku @minikin