Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

  • Fixed the part of specifying template fields for proposal, comment and review documents.
  • Improved description of the comment's ref, reply fields.
  • Added a new category_id field for the proposal document.

@Mr-Leshiy Mr-Leshiy self-assigned this Feb 6, 2025
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) February 6, 2025 14:23
@Mr-Leshiy Mr-Leshiy requested a review from stevenj February 6, 2025 14:23
saibatizoku
saibatizoku previously approved these changes Feb 6, 2025
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes look good to me, but in metadata fields for comment, proposal, review
should this be content-encoding?

"content-type" => "br"

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

@Mr-Leshiy Mr-Leshiy merged commit 5d7aa54 into main Feb 12, 2025
2 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-docs-spec branch February 12, 2025 07:53
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants