Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Feb 12, 2025

Description

  • Implement the Display trait for types generated by the define_hashes! macro.

Description of Changes

Blake2bHash implements Display, so it makes sense to implement this trait for derived types too. Also it is often used to print a user-friendly hash representation.

Related Pull Requests

input-output-hk/catalyst-voices#1367

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 279/279}$ | ${\color{red}Fail: 0/279}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit c441fb6 into main Feb 12, 2025
20 checks passed
@stanislav-tkach stanislav-tkach deleted the implement-display-for-hash-wrapper branch February 12, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants