Skip to content

Conversation

@stevenj
Copy link
Collaborator

@stevenj stevenj commented Feb 13, 2025

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Rendered schemas are here: https://input-output-hk.github.io/catalyst-libs/branch/wip_document_schemas/#

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj marked this pull request as draft February 13, 2025 17:25
@stevenj stevenj self-assigned this Feb 13, 2025
@stevenj stevenj added do not merge yet PR is not ready to be merged yet requires architect review Requires at least 1 architect to sign off on PR before merge. labels Feb 13, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 287/287}$ | ${\color{red}Fail: 0/287}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 287/287}$ | ${\color{red}Fail: 0/287}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Test Report | ${\color{lightgreen}Pass: 313/313}$ | ${\color{red}Fail: 0/313}$ |

@stevenj stevenj changed the title Wip/document schemas feat(doc): Formal Schemas for Signed Docs Mar 2, 2025
@stevenj stevenj changed the title feat(doc): Formal Schemas for Signed Docs feat(docs): Formal Schemas for Signed Docs Mar 2, 2025
@stevenj stevenj marked this pull request as ready for review March 2, 2025 14:45
@stevenj stevenj requested a review from nathanbogale March 3, 2025 05:27
… more align with intent vs business logic behaviour.
@stevenj stevenj dismissed stale reviews from nathanbogale and neil-iohk via a103636 March 5, 2025 14:10
@stevenj stevenj removed the do not merge yet PR is not ready to be merged yet label Apr 7, 2025
@stevenj stevenj merged commit 37f7644 into main Apr 7, 2025
22 checks passed
@stevenj stevenj deleted the wip/document-schemas branch April 7, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires architect review Requires at least 1 architect to sign off on PR before merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants