Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Feb 14, 2025

Description

  • Use the TransactionHash type in the rbac-registration crate.
  • Store IdUri in Cip509.

Related Pull Requests

input-output-hk/catalyst-voices#1367

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach added the do not merge yet PR is not ready to be merged yet label Feb 14, 2025
@stanislav-tkach stanislav-tkach removed the do not merge yet PR is not ready to be merged yet label Feb 14, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 287/287}$ | ${\color{red}Fail: 0/287}$ |

@stanislav-tkach stanislav-tkach added the review me PR is ready for review label Feb 14, 2025
Mr-Leshiy
Mr-Leshiy previously approved these changes Feb 14, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 287/287}$ | ${\color{red}Fail: 0/287}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit 908ea2d into main Feb 17, 2025
20 of 22 checks passed
@stanislav-tkach stanislav-tkach deleted the update-rbac-new-types branch February 17, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants