Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Aug 29, 2025

Description

Added initial basic implementation of the catalyst_signed_documents_rules! macro, which statically defines validation rules for all document types from the Catalyst Signed Document's specifications.

Related Issue(s)

Part of https://github.com/input-output-hk/catalyst-internal-docs/issues/266

Description of Changes

  • Added basic implementation of the catalyst_signed_documents_rules! macro, which will define a default validation rules for all specified document types.
  • Cleaned catalyst-signed-doc-macro crate
  • Removed unnecessary usage of Arc
  • Added Debug trait implementation for all validation rules types, so it would be easy to inspect how catalyst_signed_documents_rules! works

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Aug 29, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Aug 29, 2025
@Mr-Leshiy Mr-Leshiy requested review from apskhem and stevenj August 29, 2025 08:22
apskhem
apskhem previously approved these changes Aug 29, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy requested a review from apskhem September 1, 2025 06:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Test Report | ${\color{lightgreen}Pass: 423/423}$ | ${\color{red}Fail: 0/423}$ |

@Mr-Leshiy Mr-Leshiy merged commit c206385 into main Sep 1, 2025
22 of 25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-macro branch September 1, 2025 10:18
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants