Skip to content

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Aug 29, 2025

Description

  • Added a new module signature.rs for SignatureRule.
  • Moved validate_signatures as a part of configurable SignatureRule
  • Moved validate_signature to signature.rs
  • Added trait constraint VerifyingKeyProvider to Rules as required by validate_signature
  • Updated unit tests, merged two dummy providers into one

Related Issue(s)

Closes #498

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Aug 29, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Aug 29, 2025
@apskhem apskhem added this to Catalyst Aug 29, 2025
@apskhem apskhem added the draft Draft label Aug 29, 2025
@apskhem apskhem linked an issue Aug 29, 2025 that may be closed by this pull request
@apskhem apskhem marked this pull request as draft August 29, 2025 11:04
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Aug 29, 2025
@apskhem apskhem marked this pull request as ready for review August 29, 2025 14:23
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Aug 29, 2025
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Aug 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

Test Report | ${\color{lightgreen}Pass: 423/423}$ | ${\color{red}Fail: 0/423}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than few small comments LGTM

@Mr-Leshiy Mr-Leshiy force-pushed the feat/multisig-validation-rule branch from 337d6f2 to a356cc5 Compare September 1, 2025 06:55
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit fdce7e9 into main Sep 1, 2025
43 of 44 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/multisig-validation-rule branch September 1, 2025 09:09
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SignaturesRule validation rule

4 participants