-
Notifications
You must be signed in to change notification settings - Fork 1
fix(rust/rbac-registration): Validate witness for stake address and payment address URIs in certificate #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Contributor
|
✅ Test Report | |
stanislav-tkach
previously approved these changes
Sep 1, 2025
Signed-off-by: bkioshn <[email protected]>
stanislav-tkach
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Task could/should be picked up as work on the backend.
fyi: gatekeepers
For information - Catalyst App Backend, System Development & Integration Team
fyi: hermetics
For information - Hermes Backend, System Development & Integration Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently URIs in certificate are only validated for role0 with stake address URI.
Related Issue(s)
Closes #506
Description of Changes
This should be changed to
Breaking Changes
role_0_stake_addressesis replacedstake_addressesin CIP134 become general - change torole_stake_addressesandstake_addressesPlease confirm the following checks