Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Sep 1, 2025

Description

Currently URIs in certificate are only validated for role0 with stake address URI.

Related Issue(s)

Closes #506

Description of Changes

This should be changed to

  • If role0, certificate stake address URI must exist at least 1, and if exist, it should be witnessed
  • All roles, if there is certificate address URI (stake address or payment address), all of them should be witnessed.

Breaking Changes

  • Any registration that violate the statement mention above, will become invalid
  • role_0_stake_addresses is replaced
  • stake_addresses in CIP134 become general - change to role_stake_addresses and stake_addresses

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Sep 1, 2025
@bkioshn bkioshn added the backend Task could/should be picked up as work on the backend. label Sep 1, 2025
@bkioshn bkioshn added this to Catalyst Sep 1, 2025
@bkioshn bkioshn added fyi: hermetics For information - Hermes Backend, System Development & Integration Team fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team labels Sep 1, 2025
@bkioshn bkioshn changed the title fix(rbac-registration): Validate witness for stake address and payment address URIs in certificate fix(rust/rbac-registration): Validate witness for stake address and payment address URIs in certificate Sep 1, 2025
@bkioshn bkioshn moved this from New to 👀 In review in Catalyst Sep 1, 2025
Signed-off-by: bkioshn <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

stanislav-tkach
stanislav-tkach previously approved these changes Sep 1, 2025
@bkioshn bkioshn marked this pull request as draft September 1, 2025 08:52
Signed-off-by: bkioshn <[email protected]>
@bkioshn bkioshn marked this pull request as ready for review September 1, 2025 10:12
@bkioshn bkioshn merged commit 7ac4e5b into main Sep 3, 2025
44 of 48 checks passed
@bkioshn bkioshn deleted the fix/validate-addr-uri-witness branch September 3, 2025 08:57
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Task could/should be picked up as work on the backend. fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team fyi: hermetics For information - Hermes Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : rbac-registration - All CIP134 addresses included in certificate (x509/c509) should be witnessed

3 participants