Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 10, 2025

Description

Added an initialisation of SignatureKidRule, ParametersRule and ReplyRule implementation from the spec file.

Related Issue(s)

Closes #516, #514, #512

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Sep 10, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Sep 10, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Sep 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025

Test Report | ${\color{lightgreen}Pass: 447/447}$ | ${\color{red}Fail: 0/447}$ |

@Mr-Leshiy Mr-Leshiy changed the title feat(rust/signed-doc): SignatureKidRule initialisation from spec feat(rust/signed-doc): SignatureKidRule, ParametersRule and ReplyRule initialisation from spec Sep 11, 2025
apskhem
apskhem previously approved these changes Sep 11, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 8c26d97 into main Sep 12, 2025
25 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/kid-init branch September 12, 2025 08:11
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SignatureKidRule macro code generation ReplyRule macro code generation ParametersRule macro code generation

3 participants