Skip to content

fix(rust/catalyst-voting): Added missing feature flag, updated conversion from CtOption to Option #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2024
Merged

fix(rust/catalyst-voting): Added missing feature flag, updated conversion from CtOption to Option #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2146c15
fix rand_core dep, update Scalar from_bytes
Mr-Leshiy Oct 16, 2024
4c5511f
fix spelling
Mr-Leshiy Oct 16, 2024
bbd21ba
add decoding impl
Mr-Leshiy Oct 17, 2024
cd898be
fix
Mr-Leshiy Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/catalyst-voting/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ workspace = true

[dependencies]
anyhow = "1.0.89"
rand_core = "0.6.4"
rand_core = { version = "0.6.4", features = ["getrandom"] }
rand_chacha = "0.3.1"
curve25519-dalek = { version = "4.1.3", features = ["digest", "rand_core"] }
ed25519-dalek = { version = "2.1.1", features = ["rand_core"] }
Expand Down
3 changes: 1 addition & 2 deletions rust/catalyst-voting/src/crypto/group/ristretto255/decoding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ impl Scalar {
/// # Errors
/// - Cannot decode scalar.
pub fn from_bytes(bytes: [u8; Self::BYTES_SIZE]) -> anyhow::Result<Scalar> {
IScalar::from_canonical_bytes(bytes)
Into::<Option<_>>::into(IScalar::from_canonical_bytes(bytes))
.map(Scalar)
.into_option()
.ok_or(anyhow!("Cannot decode scalar."))
}

Expand Down
Loading