feat(rust/rbac-registration): RBAC refactoring feature branch #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in` (#586) * initial * feat: provider * feat: update chain * feat: start_new_chain * feat: merge validation result struct into cip509 * feat: exports * feat: return new chain * chore: return success object * fix: older version * feat: cat id in payload * fix: new version * chore: lintfix * chore: remove persistent arguments * tmp * chore: complete moving to central module * feat: ref fn * chore: merge methods * chore: minor * feat: export modified chains * chore: minor comment * chore: rbac update logic * chore: isolation * chore: validation and lintfix * docs: remove error doc * chore: minor refactor * fix: comments * chore: validation function return * Update rust/rbac-registration/src/providers.rs Co-authored-by: Alex Pozhylenkov <[email protected]> --------- Co-authored-by: Alex Pozhylenkov <[email protected]>
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: |
Contributor
|
✅ Test Report | |
Mr-Leshiy
added
review me
rafal-ch
reviewed
Nov 20, 2025
rust/rbac-registration/src/cardano/cip509/utils/cip134_uri_set.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rafał Chabowski <[email protected]>
bkioshn
reviewed
Nov 21, 2025
| /// Returns a list of all stake addresses. | ||
| /// Returns a set of all active (without taken) stake addresses. | ||
| #[must_use] | ||
| pub fn stake_addresses(&self) -> HashSet<StakeAddress> { |
Contributor
There was a problem hiding this comment.
active_stake_addresses would be better
Comment on lines
+124
to
+126
| let previous_addresses = self.stake_addresses(); | ||
| let reg_addresses = cip509.stake_addresses(); | ||
| let new_addresses: Vec<_> = reg_addresses.difference(&previous_addresses).collect(); |
Contributor
There was a problem hiding this comment.
I think adding stake will be more readable when glancing through
eg. previous_stake_addresses
| /// Get the latest encryption public key for a role. | ||
| /// Returns the public key and the rotation, `None` if not found. | ||
| #[must_use] | ||
| pub fn get_latest_encryption_pk_for_role( |
Contributor
There was a problem hiding this comment.
For consistency, if we are using public_key instead of pk this should be renamed, also other pk function too
| ) -> impl Future<Output = anyhow::Result<Option<CatalystId>>> + Send; | ||
|
|
||
| /// Update the chain by "taking" the given `StakeAddress` for the corresponding | ||
| /// RBAC chain's by the given `CatalystId`. |
Contributor
There was a problem hiding this comment.
This comment is a bit confusing (for me 😅)
| addr: &StakeAddress, | ||
| ) -> impl Future<Output = anyhow::Result<bool>> + Send; | ||
|
|
||
| /// Returns a corresponding to the RBAC chain's Catalyst ID corresponding by the given |
Contributor
There was a problem hiding this comment.
This one too. Maybe
"Returns the Catalyst ID associated with the RBAC chain for the given signing public key"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Pull Requests
RegistrationChain#586StakeAddresshandling. #631Cip0134UriSet#655Cip0134UriSetdata #658Please confirm the following checks