chore(rust/signed-doc): Add doc_ref method for CatalystSignedDoc.
#640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
added
squad: gatekeepers
saibatizoku
approved these changes
Nov 14, 2025
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: |
Contributor
|
✅ Test Report | |
saibatizoku
merged commit 53a8829
into
fix/doclocator-uses-cid-v1
30 of 37 checks passed
saibatizoku
added a commit
that referenced
this pull request
Nov 16, 2025
* feat(rust/signed-doc): CatalystSignedDocument has CIDv1 * feat(rust/signed-doc): Cid newtype * break(rust/signed-doc): DocLocator(Cid) must be valid * Breaking change that removes compatibility with old versions * fix(rust/signed-doc): fix unit tests to support DocLocator * removes support for old version * fix(rust/signed-doc): fix integration tests * chore(rust/signed-doc): fmt fix * chore(rust/signed-doc): fix spelling * chore(rust/signed-doc): fix doc comment * chore(rust/signed-doc): Add `doc_ref` method for `CatalystSignedDoc`. (#640) * update API * wip * wip * wip * fix test * wip * wip * fix fmt * fix(rust/signed-doc): remove stale example --------- Co-authored-by: Joaquín Rosales <[email protected]> --------- Co-authored-by: Alex Pozhylenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slightly refactored the usage of the new
DocumentLocatortype and generation it for the particular document.Fixed existing tests by setting the correct
DocumentRefvalues.Description of Changes
doc_ref(&self) -> anyhow::Result<DocumentRef>method for theCatalystSignedDoctype instead ofTryFrom<&CatalystSignedDoc> for DocumentRef.create_dummy_doc_locatorwith thecreate_dummy_document_refTestCatalystProvider::add_document, added separateTestCatalystProvider ::add_document_with_refinstead.Related Pull Requests
Refactoring for #621
Please confirm the following checks