Skip to content

Conversation

@nathanbogale
Copy link
Contributor

Summary

Updates the ver field validation specification as described in #502.

Changes

  • Added all 4 validation rules to ver field validation in CUE definitions
  • Moved versioning rule from id to ver validation (cleanup)
  • Updated id validation to describe timestamp-based validation
  • Updated generated signed_doc.json to reflect CUE changes

Related

Notes

  • Markdown documentation will be regenerated automatically from the updated JSON
  • The CUE source files are the source of truth for the specification

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

- Add all 4 validation rules to ver field validation:
  1. Version must be >= ID
  2. First version requirement (moved from id validation)
  3. Version increment rule
  4. Document type consistency rule
- Move versioning rule from id to ver validation
- Update id validation to describe timestamp-based validation

Closes #502
@nathanbogale nathanbogale self-assigned this Nov 17, 2025
@nathanbogale nathanbogale added the review me PR is ready for review label Nov 17, 2025
@nathanbogale nathanbogale moved this from New to 👀 In review in Catalyst Nov 17, 2025
@nathanbogale nathanbogale changed the title fix(specs): update ver field validation specification per #502 fix(docs): update ver field validation specification per #502 Nov 17, 2025
…metadata

- Refine ID validation to include timestamp thresholds for future and past limits.
- Enhance version validation with detailed rules for versioning consistency and type matching.
- Ensure clarity and consistency across documentation for signed documents.
…ument metadata

- Improve formatting for ID and version validation rules across multiple documentation files.
- Ensure consistency in the presentation of validation criteria for better readability.
- Update the signed_doc.json specification to reflect the new formatting standards.
…nt metadata

- Improve formatting for ID validation rules across multiple documentation files to enhance readability.
- Ensure consistent presentation of timestamp threshold criteria for better clarity.
- Update the signed_doc.json specification to reflect the new formatting standards.
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 17, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…cument metadata

- Refine formatting for ID validation rules across multiple documentation files to enhance readability and consistency.
- Ensure timestamp threshold criteria are clearly presented for both future and past limits.
- Update the signed_doc.json specification to reflect the improved formatting standards.
…nt metadata

- Standardize the presentation of ID validation rules across multiple documentation files to improve readability.
- Add missing newlines for better separation of criteria related to timestamp thresholds for future and past limits.
- Update the signed_doc.json specification to reflect the improved formatting standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Catalyst Signed Documents ver field validation specification

3 participants