-
Notifications
You must be signed in to change notification settings - Fork 1
fix(docs): update ver field validation specification per #502 #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nathanbogale
wants to merge
9
commits into
main
Choose a base branch
from
fix/502-ver-validation-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add all 4 validation rules to ver field validation: 1. Version must be >= ID 2. First version requirement (moved from id validation) 3. Version increment rule 4. Document type consistency rule - Move versioning rule from id to ver validation - Update id validation to describe timestamp-based validation Closes #502
…metadata - Refine ID validation to include timestamp thresholds for future and past limits. - Enhance version validation with detailed rules for versioning consistency and type matching. - Ensure clarity and consistency across documentation for signed documents.
…ument metadata - Improve formatting for ID and version validation rules across multiple documentation files. - Ensure consistency in the presentation of validation criteria for better readability. - Update the signed_doc.json specification to reflect the new formatting standards.
…nt metadata - Improve formatting for ID validation rules across multiple documentation files to enhance readability. - Ensure consistent presentation of timestamp threshold criteria for better clarity. - Update the signed_doc.json specification to reflect the new formatting standards.
Mr-Leshiy
previously approved these changes
Nov 17, 2025
Contributor
Mr-Leshiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…cument metadata - Refine formatting for ID validation rules across multiple documentation files to enhance readability and consistency. - Ensure timestamp threshold criteria are clearly presented for both future and past limits. - Update the signed_doc.json specification to reflect the improved formatting standards.
…nt metadata - Standardize the presentation of ID validation rules across multiple documentation files to improve readability. - Add missing newlines for better separation of criteria related to timestamp thresholds for future and past limits. - Update the signed_doc.json specification to reflect the improved formatting standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
verfield validation specification as described in #502.Changes
verfield validation in CUE definitionsidtovervalidation (cleanup)idvalidation to describe timestamp-based validationsigned_doc.jsonto reflect CUE changesRelated
verfield validation specification #502validate_id_and_veras separate rulesIdRuleandVerRule#497 (library implementation)Notes