Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Added benchmarks for all of the steps of the catalyst vote protocol.
Refactored some stuff.

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 22, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 22, 2024
@Mr-Leshiy Mr-Leshiy requested review from minikin and stevenj October 22, 2024 08:11
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we publish benchmark results, e.g. in README?

@Mr-Leshiy
Copy link
Contributor Author

@minikin not sure that its actually what we want here, because I will post a results made on my machine, so they will be not the same if some other will run it.
Maybe we need to define a general strategy how we want to run our benchmarks on some regular basis, maybe something the same as we have codecov reports.
Seems we need to raise this topic on our tech discussions and decide what to do.

@minikin minikin enabled auto-merge (squash) October 23, 2024 09:05
@minikin
Copy link
Collaborator

minikin commented Oct 23, 2024

@Mr-Leshiy, can you please create a task about publishing benchmark results? Let's discuss this topic in our next technical discussion.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Test Report | ${\color{lightgreen}Pass: 211/211}$ | ${\color{red}Fail: 0/211}$ |

Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 2f9277f into main Oct 29, 2024
10 of 11 checks passed
@minikin minikin deleted the feat/add-voting-benchmark branch October 29, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants