Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 22, 2024

Description

Added a design spec for the catalyst transaction v2.

Docs link:
https://input-output-hk.github.io/catalyst-libs/branch/docs_vote_tx_v2/architecture/08_concepts/catalyst_voting/transaction/#v2

Related Issue(s)

Closes #64

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 22, 2024
@Mr-Leshiy Mr-Leshiy added the do not merge yet PR is not ready to be merged yet label Oct 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Test Report | ${\color{lightgreen}Pass: 211/211}$ | ${\color{red}Fail: 0/211}$ |

@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 22, 2024
@Mr-Leshiy Mr-Leshiy removed the do not merge yet PR is not ready to be merged yet label Oct 22, 2024
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In section Example - V1 transaction representation in hex:
2. 00 add what this 00 means

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit c150746 into main Oct 23, 2024
22 checks passed
@minikin minikin deleted the docs/vote-tx-v2 branch October 23, 2024 09:04
@Mr-Leshiy Mr-Leshiy requested a review from bkioshn October 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK]: Generalised Catalyst voting v2 transaction design spec.

4 participants