Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Added missing default values for signed document generator functions, fixed typos.

Related Pull Requests

Needed for input-output-hk/catalyst-voices#3817

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Dec 8, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Dec 8, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/signed-doc-default-values

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Test Report | ${\color{lightgreen}Pass: 601/601}$ | ${\color{red}Fail: 0/601}$ |

Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 812c9a8 into main Dec 8, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-default-values branch December 8, 2025 10:23
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants