-
Notifications
You must be signed in to change notification settings - Fork 1
feat(rust/hermes-ipfs): ipfs transport enable methods #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add wrapper methods to enable TCP, QUIC, and DNS transports in HermesIpfsBuilder. These methods are required because connexa's TransportConfig disables all transports by default. - Add enable_tcp() method - Add enable_quic() method - Add enable_dns() method Without these methods, libp2p connections fail with "Multiaddr is not supported" errors. The methods must be called explicitly when building an IPFS node to enable P2P networking. Related to: #704
…sport-enable-methods # Conflicts: # rust/hermes-ipfs/Cargo.toml
Use the 'full' feature flag for connexa dependency instead of explicitly listing individual features. This is more maintainable and cleaner. Or if you prefer a shorter version:
Format where clauses and add TODO comments documenting disabled default transport config and TLS/websocket options.
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/libs/feat/hermes-ipfs-transport-enable-methods |
|
✅ Test Report | |
aido-mth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
no30bit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add transport configuration methods to HermesIpfsBuilder
Summary:
Adds builder methods to HermesIpfsBuilder for configuring libp2p transports, enabling Hermes to customize network transport settings for different deployment environments.
Changes:
Added three new builder methods to HermesIpfsBuilder:
Reason:
Currently, HermesIpfsBuilder doesn't expose transport configuration options from the underlying rust-ipfs IpfsBuilder. This limits Hermes' ability to:
These methods are needed for Hermes to implement P2P features (pubsub, DHT) in a multi-node test environment where nodes run in isolated Docker containers and need to discover each
other.
Usage
Implementation
Downstream Impact
This enables Hermes to:
Testing
Can be verified downstream in Hermes by: