-
Notifications
You must be signed in to change notification settings - Fork 1
fix(rust/hermes-ipfs): Fix add_ipfs_file and get_ipfs_file
#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
|
CI fails here, but pass locally |
cong-or
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
with one nit
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
|
Might need to fix bitswap, still investigate |
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Description
Fix
add_ipfs_fileandget_ipfs_fileRelated Issue(s)
input-output-hk/hermes#736
Description of Changes
add_ipfs_fileget_ipfs_fileGet a file from a block using CID instead of getting it from unixfs
Remove
Note : The underlying implementation of unixfs undergoes a chunking mechanism when the file is big.
This create block doesn't handle that process and yet it is safe since the documents size is limit to ~2MB
Breaking Changes
add_ipfs_fileandget_ipfs_fileAddIpfsFileis removedRelated Pull Requests
input-output-hk/hermes#750
Please confirm the following checks