Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 6, 2026

Description

Fix add_ipfs_file and get_ipfs_file

Related Issue(s)

input-output-hk/hermes#736

Description of Changes

add_ipfs_file

  • Creating a block using custom CID and data to store the file instead of using unixfs

get_ipfs_file

  • Get a file from a block using CID instead of getting it from unixfs

  • Remove
    Note : The underlying implementation of unixfs undergoes a chunking mechanism when the file is big.
    This create block doesn't handle that process and yet it is safe since the documents size is limit to ~2MB

Breaking Changes

  • New implementation of add_ipfs_file and get_ipfs_file
  • AddIpfsFile is removed

Related Pull Requests

input-output-hk/hermes#750

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Jan 6, 2026
@bkioshn bkioshn added the squad: hermetics Hermes Backend, System Development & Integration Team label Jan 6, 2026
@bkioshn bkioshn added this to Catalyst Jan 6, 2026
@bkioshn bkioshn marked this pull request as ready for review January 7, 2026 06:36
@bkioshn
Copy link
Contributor Author

bkioshn commented Jan 7, 2026

CI fails here, but pass locally

@bkioshn bkioshn moved this from New to 👀 In review in Catalyst Jan 7, 2026
@bkioshn bkioshn requested review from cong-or and rafal-ch January 7, 2026 10:30
cong-or
cong-or previously approved these changes Jan 7, 2026
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafal-ch
rafal-ch previously approved these changes Jan 7, 2026
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
with one nit

@bkioshn bkioshn dismissed stale reviews from rafal-ch and cong-or via 877d925 January 7, 2026 13:28
rafal-ch
rafal-ch previously approved these changes Jan 7, 2026
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
@bkioshn bkioshn marked this pull request as draft January 8, 2026 07:57
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
@bkioshn bkioshn marked this pull request as ready for review January 8, 2026 10:13
@bkioshn bkioshn marked this pull request as draft January 9, 2026 10:31
@bkioshn
Copy link
Contributor Author

bkioshn commented Jan 9, 2026

Might need to fix bitswap, still investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: hermetics Hermes Backend, System Development & Integration Team

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants