Skip to content

chore(rust): subscription_stream_task() uses async handlers#839

Merged
rafal-ch merged 3 commits intomainfrom
updates_to_async_in_hermes_ipfs
Feb 3, 2026
Merged

chore(rust): subscription_stream_task() uses async handlers#839
rafal-ch merged 3 commits intomainfrom
updates_to_async_in_hermes_ipfs

Conversation

@rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Feb 2, 2026

Description

This PR makes a small improvement to the IPFS subscription stream task so that it accepts handlers which return futures. This allows the handler to be async.

It also bumps the crate version.

Related Issue(s)

n/a

Description of Changes

See Description above.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

n/a

Related Pull Requests

Required for Hermes improvements begin prepared here: input-output-hk/hermes#797

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@rafal-ch rafal-ch self-assigned this Feb 2, 2026
@rafal-ch rafal-ch added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet squad: hermetics Hermes Backend, System Development & Integration Team labels Feb 2, 2026
@rafal-ch rafal-ch removed do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Feb 3, 2026
@rafal-ch rafal-ch added this to Catalyst Feb 3, 2026
@rafal-ch rafal-ch changed the title subscription_stream_task() uses async handlers chore(rust): subscription_stream_task() uses async handlers Feb 3, 2026
@rafal-ch rafal-ch moved this from New to 👀 In review in Catalyst Feb 3, 2026
@rafal-ch rafal-ch marked this pull request as ready for review February 3, 2026 11:46
@rafal-ch rafal-ch requested a review from cong-or February 3, 2026 11:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/updates_to_async_in_hermes_ipfs

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Test Report | ${\color{lightgreen}Pass: 728/728}$ | ${\color{red}Fail: 0/728}$ |

Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafal-ch rafal-ch merged commit cdb4ef6 into main Feb 3, 2026
29 of 33 checks passed
@rafal-ch rafal-ch deleted the updates_to_async_in_hermes_ipfs branch February 3, 2026 15:39
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: hermetics Hermes Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants