Skip to content

fix(rust/rbac-registration): extract type in CIP509 to its own file and implement conversion #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 6, 2024
Merged

fix(rust/rbac-registration): extract type in CIP509 to its own file and implement conversion #97

merged 8 commits into from
Dec 6, 2024

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 4, 2024 •
edited
Loading

Description

  • Extract type in CIP509 to its own file and implement conversion
  • Use Uuid from uuid and VerifyingKey from ed25519-dalek

@bkioshn bkioshn marked this pull request as draft December 4, 2024 12:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 253/253}$ | ${\color{red}Fail: 0/253}$ |

@bkioshn bkioshn self-assigned this Dec 4, 2024
@bkioshn bkioshn marked this pull request as ready for review December 6, 2024 03:50
@bkioshn bkioshn added the enhancement New feature or request label Dec 6, 2024
@bkioshn
chore: fix naming
7dde426 
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
Mr-Leshiy requested changes Dec 6, 2024
View reviewed changes
@stevenj stevenj enabled auto-merge (squash) December 6, 2024 14:26
stevenj
stevenj approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj disabled auto-merge December 6, 2024 14:26
@stevenj stevenj merged commit 1747c61 into main Dec 6, 2024
24 checks passed
@stevenj stevenj deleted the fix/rbac-cip509-type branch December 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy requested changes

@stevenj stevenj stevenj approved these changes

Assignees

@bkioshn bkioshn

Labels

enhancement New feature or request

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkioshn @stevenj @Mr-Leshiy