chore(cat-voices): disposing more objects (#2156)

* chore: dispose db

* chore: close safe ProposalsCubit

* chore: UserService safe check

Author: damian-molinski

catalyst_voices/apps/voices/lib/app/view/app_active_state_listener.dart

@@ -18,32 +18,38 @@ class AppActiveStateListener extends StatefulWidget {
 
 class _AppActiveStateListenerState extends State<AppActiveStateListener> {
   late final AppLifecycleListener _listener;
+  UserService? _userService;
 
   @override
-  void initState() {
-    super.initState();
-    _listener = AppLifecycleListener(
-      onResume: _handleResumed,
-      onInactive: _handleInactive,
-    );
+  Widget build(BuildContext context) {
+    return widget.child;
   }
 
   @override
   void dispose() {
+    _userService = null;
     _listener.dispose();
     super.dispose();
   }
 
   @override
-  Widget build(BuildContext context) {
-    return widget.child;
-  }
+  void initState() {
+    super.initState();
 
-  Future<void> _handleResumed() async {
-    Dependencies.instance.get<UserService>().isActive = true;
+    _userService = Dependencies.instance.isRegistered<UserService>()
+        ? Dependencies.instance.get<UserService>()
+        : null;
+    _listener = AppLifecycleListener(
+      onResume: _handleResumed,
+      onInactive: _handleInactive,
+    );
   }
 
   Future<void> _handleInactive() async {
-    Dependencies.instance.get<UserService>().isActive = false;
+    _userService?.isActive = false;
+  }
+
+  Future<void> _handleResumed() async {
+    _userService?.isActive = true;
   }
 }

catalyst_voices/apps/voices/lib/dependency/dependencies.dart

@@ -299,19 +299,22 @@ final class Dependencies extends DependencyProvider {
     registerLazySingleton<FlutterSecureStorage>(FlutterSecureStorage.new);
     registerLazySingleton<SharedPreferencesAsync>(SharedPreferencesAsync.new);
     registerLazySingleton<UserStorage>(SecureUserStorage.new);
-    registerLazySingleton<CatalystDatabase>(() {
-      final config = get<AppConfig>().database;
+    registerLazySingleton<CatalystDatabase>(
+      () {
+        final config = get<AppConfig>().database;
 
-      return CatalystDatabase.drift(
-        config: CatalystDriftDatabaseConfig(
-          name: config.name,
-          web: CatalystDriftDatabaseWebConfig(
-            sqlite3Wasm: Uri.parse(config.webSqlite3Wasm),
-            driftWorker: Uri.parse(config.webDriftWorker),
+        return CatalystDatabase.drift(
+          config: CatalystDriftDatabaseConfig(
+            name: config.name,
+            web: CatalystDriftDatabaseWebConfig(
+              sqlite3Wasm: Uri.parse(config.webSqlite3Wasm),
+              driftWorker: Uri.parse(config.webDriftWorker),
+            ),
           ),
-        ),
-      );
-    });
+        );
+      },
+      dispose: (database) async => database.close(),
+    );
     registerLazySingleton<AuthTokenCache>(() {
       return LocalAuthTokenCache(
         sharedPreferences: get<SharedPreferencesAsync>(),

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart

@@ -39,13 +39,17 @@ final class ProposalsCubit extends Cubit<ProposalsState> {
       (index) => CampaignCategoryDetailsViewModel.dummy(id: '$index'),
     );
 
-    emit(state.copyWith(categories: categories));
+    if (!isClosed) {
+      emit(state.copyWith(categories: categories));
+    }
   }
 
   Future<void> getFavoritesList() async {
     final favoritesList = await _proposalService.getFavoritesProposalsIds();
 
-    emit(state.copyWith(favoritesIds: favoritesList));
+    if (!isClosed) {
+      emit(state.copyWith(favoritesIds: favoritesList));
+    }
   }
 
   Future<void> getProposals(

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/database/catalyst_database.dart

@@ -39,6 +39,11 @@ abstract interface class CatalystDatabase {
 
   /// Removes all data from this db.
   Future<void> clear();
+
+  /// Only once instance is allowed.
+  ///
+  /// In tests it can happen that database was opened and disposed later.
+  Future<void> close();
 }
 
 @DriftDatabase(

catalyst_voices/packages/internal/catalyst_voices_shared/lib/src/dependency/dependency_provider.dart

@@ -30,6 +30,8 @@ abstract class DependencyProvider {
     return _getIt.allReady();
   }
 
+  bool isRegistered<T extends Object>() => _getIt.isRegistered<T>();
+
   T get<T extends Object>() => _getIt.get<T>();
 
   Future<T> getAsync<T extends Object>() => _getIt.getAsync<T>();