Skip to content

feat(cat-voices): Update stakeAssets endpoint to v2 #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

feat(cat-voices): Update stakeAssets endpoint to v2 #3621

merged 1 commit into from
Oct 31, 2025

Conversation

@bstolinski
Copy link
Contributor

@bstolinski bstolinski commented Oct 31, 2025

Description

Update Catalyst Gateway service interface to 0.7.0 spec

Related Issue(s)

Closes #3619
Part of #3362

Description of Changes

GET /v2/cardano/assets - move stake_address from path to optional query parameter

Related Pull Requests

#3602

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bstolinski bstolinski self-assigned this Oct 31, 2025
@bstolinski bstolinski added the squad: face Frontend Catalyst Experience Team label Oct 31, 2025
@bstolinski bstolinski marked this pull request as ready for review October 31, 2025 07:48
@bstolinski bstolinski changed the title feat: Update stakeAssets endpoint to v2 feat(cat-voices): Update stakeAssets endpoint to v2 Oct 31, 2025
@bstolinski bstolinski changed the title feat(cat-voices): Update stakeAssets endpoint to v2 feat(cat-voices): Update stakeAssets endpoint to v2 Oct 31, 2025
@bstolinski bstolinski added the review me PR is ready for review label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/feat/update-cat-gateway-service-interface-to-0.7.0-spec

dt-iohk
dt-iohk approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@dt-iohk dt-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski added the fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team label Oct 31, 2025
@damian-molinski damian-molinski moved this from New to 👀 In review in Catalyst Oct 31, 2025
damian-molinski
damian-molinski approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bstolinski bstolinski merged commit c593207 into feat/sync-with-gateway-v2-endpoints-3362 Oct 31, 2025
74 of 78 checks passed
@bstolinski bstolinski deleted the feat/update-cat-gateway-service-interface-to-0.7.0-spec branch October 31, 2025 08:51
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@dt-iohk dt-iohk dt-iohk approved these changes

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx is a code owner

Assignees

@bstolinski bstolinski

Labels

fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team review me PR is ready for review squad: face Frontend Catalyst Experience Team

Projects

Catalyst
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bstolinski @damian-molinski @dt-iohk