feat(cat-gateway): RBAC updates #3729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion` table (#3724) * remove `removed_addresses` from the `rbac_registration` table * fix clippy * wip
Mr-Leshiy
requested review from
bkioshn,
cong-or,
saibatizoku,
stanislav-tkach and
stevenj
as code owners
Mr-Leshiy
added
squad: gatekeepers
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: |
stanislav-tkach
previously approved these changes
Nov 19, 2025
|
|
||
| // Update other chains that were affected by this registration. | ||
| for (catalyst_id, removed_addresses) in modified_chains { | ||
| for (catalyst_id, _) in modified_chains { |
Member
There was a problem hiding this comment.
I think we can update RbacValidationSuccess::modified_chains because we no longer need the stake addresses there. Am I missing something?
…3730) * apply latest `rbac-registration` crate * fix * cleanup * fix * fix spelling * wip * fix clippy
Mr-Leshiy
added
review me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature branch which would contain all RBAC improvements for the
cat-gatewayRelated Issue(s)
Closes #3507
Related Pull Requests
removed_addressesfrom therbac_registrationtable #3724rbac-registrationcrate version #3730Please confirm the following checks