Skip to content

Conversation

@damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Nov 20, 2025

Description

This PR prepares codebase for removing hardcoded templates refs

Related Issue(s)

Closes #3742

Description of Changes

  • Removes proposalTemplateRef from CampaignCategory and instead just query DB for docs with correct type. (f14 and f15 still have their hardcoded values
  • DAO level implementation is "not ideal" as it will be redone on performance branch anyway

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this Nov 20, 2025
@damian-molinski damian-molinski added squad: face Frontend Catalyst Experience Team fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team labels Nov 20, 2025
@damian-molinski damian-molinski moved this from New to 👀 In review in Catalyst Nov 20, 2025
@damian-molinski damian-molinski moved this from 👀 In review to 🏗 In progress in Catalyst Nov 20, 2025
@damian-molinski damian-molinski marked this pull request as ready for review November 20, 2025 20:21
@damian-molinski damian-molinski moved this from 🏗 In progress to 👀 In review in Catalyst Nov 20, 2025
@damian-molinski damian-molinski changed the title feat(cat-voices): dynamic templates ids 3742 feat(cat-voices): dynamic templates refs Nov 20, 2025
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/voices/feat/dynamic_templates_ids_3742

@damian-molinski damian-molinski merged commit b495c5a into feat/sync-with-gateway-v2-endpoints-3362 Nov 21, 2025
39 of 40 checks passed
@damian-molinski damian-molinski deleted the feat/dynamic_templates_ids_3742 branch November 21, 2025 12:43
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fyi: gatekeepers For information - Catalyst App Backend, System Development & Integration Team squad: face Frontend Catalyst Experience Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants