Skip to content

Simplify runTermE (runtime-wise) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

Simplify runTermE (runtime-wise) #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e069718
simplify runTermE
MaximilianAlgehed Nov 16, 2025
1f4f7ea
explain what we're doing
MaximilianAlgehed Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Constrained/AbstractSyntax.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ runTermE env = \case
V v -> case Env.lookup env v of
Just a -> Right a
Nothing -> Left (pure ("Couldn't find " ++ show v ++ " in " ++ show env))
-- The first two cases here are an optimization to avoid dispatching to `mapMList` (which does all sorts of
-- unpacking and packing and doesn't fuse nicely with `uncurryList_`)
App f (ta :> Nil) -> semantics f <$> runTermE env ta
App f (ta :> tb :> Nil) -> semantics f <$> runTermE env ta <*> runTermE env tb
App f ts -> do
vs <- mapMList (fmap Identity . runTermE env) ts
pure $ uncurryList_ runIdentity (semantics f) vs
Expand Down
Loading