[DDW-880] Forward data attributes to input field components (#2841)

Co-authored-by: Daniel Main <[email protected]>

Author: renanvalentin

package.json

@@ -248,7 +248,7 @@
     "react-intl": "2.7.2",
     "react-lottie": "1.2.3",
     "react-markdown": "4.3.1",
-    "react-polymorph": "1.0.1",
+    "react-polymorph": "1.0.2",
     "react-router": "5.2.0",
     "react-router-dom": "5.2.0",
     "react-svg-inline": "2.1.1",

source/renderer/app/components/wallet/WalletSendForm.spec.tsx

@@ -108,15 +108,11 @@ describe('wallet/Wallet Send Form', () => {
   }
 
   function getInput(label: string) {
-    return screen
-      .getByText(label)
-      .closest('label')
-      .parentElement.querySelector('input');
+    return screen.getByLabelText(label);
   }
 
   async function findInput(label: string) {
-    await screen.findByText(label);
-    return getInput(label);
+    return screen.findByLabelText(label);
   }
 
   async function addToken(value = 1, tokenIndex = 0) {
@@ -129,7 +125,10 @@ describe('wallet/Wallet Send Form', () => {
     fireEvent.click(tokenCheckbox);
     const addTokenPickerButton = await screen.findByText('Add');
     fireEvent.click(addTokenPickerButton);
-    const token = await findInput(assets[tokenIndex].metadata.name);
+
+    const { uniqueId } = assets[tokenIndex];
+
+    const token = await screen.findByTestId(`assetInput:${uniqueId}`);
     fireEvent.change(token, {
       target: {
         value,
@@ -138,7 +137,7 @@ describe('wallet/Wallet Send Form', () => {
     return async () => {
       fireEvent.mouseEnter(token);
       const removeTokenButton = await screen.findByTestId(
-        `remove-asset-${assets[tokenIndex].uniqueId}`
+        `removeAsset:${uniqueId}`
       );
       fireEvent.click(removeTokenButton);
     };

source/renderer/app/components/wallet/send-form/AssetInput.tsx

@@ -121,6 +121,7 @@ class AssetInput extends Component<Props> {
                 small
               />
             }
+            data-testid={`assetInput:${uniqueId}`}
             bigNumberFormat={decimals ? currentNumberFormat : null}
             decimalPlaces={decimals}
             numberLocaleOptions={{
@@ -182,7 +183,7 @@ class AssetInput extends Component<Props> {
           <span
             className={classNames([styles.removeAssetButton, 'flat'])}
             onClick={() => removeAssetRow(uniqueId)}
-            data-testid={`remove-asset-${uniqueId}`}
+            data-testid={`removeAsset:${uniqueId}`}
           >
             <SVGInline svg={removeIcon} className={styles.removeIcon} />
           </span>

yarn.lock

@@ -8315,9 +8315,11 @@ fill-range@^4.0.0:
     repeat-string "^1.6.1"
     to-regex-range "^2.1.0"
 
-[email protected]:
-  version "0.0.2"
-  resolved "https://registry.yarnpkg.com/filter-react-dom-props/-/filter-react-dom-props-0.0.2.tgz#d5c1e5a89c13534cebe3930a22afa9ae3238813b"
+[email protected]:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/filter-invalid-dom-props/-/filter-invalid-dom-props-2.1.0.tgz#7690bb72e9213a09e8429c07f3aea21468f43ee5"
+  dependencies:
+    html-attributes "1.1.0"
 
 finalhandler@~1.1.2:
   version "1.1.2"
@@ -9406,6 +9408,10 @@ hosted-git-info@^2.1.4:
   version "2.8.8"
   resolved "https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.8.8.tgz#7539bd4bc1e0e0a895815a2e0262420b12858488"
 
+[email protected]:
+  version "1.1.0"
+  resolved "https://registry.yarnpkg.com/html-attributes/-/html-attributes-1.1.0.tgz#82027a4fac7a6070ea6c18cc3886aea18d6dea09"
+
 html-encoding-sniffer@^2.0.1:
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/html-encoding-sniffer/-/html-encoding-sniffer-2.0.1.tgz#42a6dc4fd33f00281176e8b23759ca4e4fa185f3"
@@ -14139,14 +14145,15 @@ [email protected]:
     prop-types "^15.5.10"
     warning "^3.0.0"
 
-[email protected].1:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/react-polymorph/-/react-polymorph-1.0.1.tgz#94e664e173b3b4a32c13953291e92fa34a05c8a7"
+[email protected].2:
+  version "1.0.2"
+  resolved "https://registry.yarnpkg.com/react-polymorph/-/react-polymorph-1.0.2.tgz#c4a36e32744fa7c2c0cfbf78aff02382cece3017"
   dependencies:
     "@tippyjs/react" "4.2.1"
     create-react-context "0.2.2"
     fast-password-entropy "1.1.1"
-    filter-react-dom-props "0.0.2"
+    filter-invalid-dom-props "2.1.0"
+    html-attributes "1.1.0"
     popper.js "1.16.1"
     react-modal "3.1.12"
     react-scrollbars-custom "4.0.21"