Skip to content

Commit d3cfbfb

Browse files
authored
Merge pull request #3116 from input-output-hk/chore/new-darwin-builders
2 parents b584a26 + 822b5eb commit d3cfbfb

File tree

5 files changed

+19
-18
lines changed

5 files changed

+19
-18
lines changed

.buildkite/pipeline.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,29 @@ steps:
99
key: 'trigger-aarch64-darwin'
1010

1111
- label: 'daedalus-x86_64-darwin'
12-
command: 'scripts/with-nix-2.5.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
12+
command: 'scripts/with-nix-unstable.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
1313
depends_on: 'trigger-x86_64-darwin'
1414
agents:
15-
queue: daedalus
15+
queue: lace
1616
system: x86_64-darwin
1717

1818
- label: 'daedalus-aarch64-darwin'
19-
command: 'scripts/with-nix-2.5.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
19+
command: 'scripts/with-nix-unstable.sh scripts/build-installer-unix.sh --build-id $BUILDKITE_BUILD_NUMBER'
2020
depends_on: 'trigger-aarch64-darwin'
21-
env:
22-
UPLOAD_DIR_OVERRIDE: UNSAFE-internal-build
2321
agents:
24-
queue: daedalus
22+
queue: lace
2523
system: aarch64-darwin
2624

2725
- label: 'daedalus-x86_64-linux-nix'
28-
command: 'scripts/with-nix-2.5.sh scripts/build-installer-nix.sh $BUILDKITE_BUILD_NUMBER'
26+
command: 'scripts/with-nix-unstable.sh scripts/build-installer-nix.sh $BUILDKITE_BUILD_NUMBER'
2927
agents:
28+
queue: lace
3029
system: x86_64-linux
3130

3231
- label: 'daedalus-x86_64-windows-nix'
33-
command: 'scripts/with-nix-2.5.sh scripts/build-cross-windows.sh $BUILDKITE_BUILD_NUMBER'
32+
command: 'scripts/with-nix-unstable.sh scripts/build-cross-windows.sh $BUILDKITE_BUILD_NUMBER'
3433
agents:
34+
queue: lace
3535
system: x86_64-linux
3636

3737
# TODO: Re-enable once script is fixed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@
88

99
### Chores
1010

11-
- Updated `@cardano-foundation/ledgerjs-hw-app-cardano` to version `6.0.0` ([PR 3093](https://github.com/input-output-hk/daedalus/pull/3093))
11+
- Prepared an official `aarch64-darwin` build ([PR 3116](https://github.com/input-output-hk/daedalus/pull/3116))
1212
- Added regeneration of dev TLS certificates for cardano-wallet on each nix-shell entry ([PR 3117](https://github.com/input-output-hk/daedalus/pull/3117))
13+
- Updated `@cardano-foundation/ledgerjs-hw-app-cardano` to version `6.0.0` ([PR 3093](https://github.com/input-output-hk/daedalus/pull/3093))
1314

1415
## 5.2.0
1516

installers/common/MacInstaller.hs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,9 @@ XML_PATH="$4"
121121
ABS_PATH="$(pwd)/$REL_PATH"
122122
TS="$(date +%Y-%m-%d_%H-%M-%S)"
123123
function sign_cmd() {
124-
codesign --verbose=4 --deep --strict --timestamp --options=runtime --entitlements $XML_PATH --sign "$SIGN_ID" "$1" 2>&1 | tee -a /tmp/codesign-output-${TS}.txt
124+
for targetFile in "$@" ; do
125+
codesign --force --verbose=4 --deep --strict --timestamp --options=runtime --entitlements $XML_PATH --sign "$SIGN_ID" "$targetFile" 2>&1 | tee -a /tmp/codesign-output-${TS}.txt
126+
done
125127
}
126128
VERIFY_CMD="codesign --verbose=4 --verify --deep --strict"
127129
ENTITLEMENT_CMD="codesign -d --entitlements :-"
@@ -160,6 +162,7 @@ sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/tiny-secp256k1/build/Rel
160162
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/tiny-secp256k1/bin/darwin-x64-"*"/tiny-secp256k1.node"
161163
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/tiny-secp256k1/bin/darwin-arm64-"*"/tiny-secp256k1.node"
162164
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/usb-detection/build/Release/detection.node"
165+
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/usb-detection/bin/darwin-arm64-"*"/usb-detection.node"
163166
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/node-hid/bin/darwin-x64-"*"/node-hid.node"
164167
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/node-hid/build/Release/HID.node"
165168

@@ -182,6 +185,8 @@ codeSignEntitlements = [r|<?xml version="1.0" encoding="UTF-8"?>
182185
<true/>
183186
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
184187
<true/>
188+
<key>com.apple.security.cs.allow-jit</key>
189+
<true/>
185190
</dict>
186191
</plist>|]
187192

scripts/build-installer-unix.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,7 @@ pushd installers
135135
then
136136
echo "Uploading the installer package.."
137137
export PATH=${BUILDKITE_BIN_PATH:-}:$PATH
138-
if [ -n "${UPLOAD_DIR_OVERRIDE:-}" ] ; then
139-
upload_dir="$UPLOAD_DIR_OVERRIDE"
140-
mv "$APP_NAME" "$upload_dir"
141-
else
142-
upload_dir="$APP_NAME"
143-
fi
138+
upload_dir="$APP_NAME"
144139
upload_artifacts_public "${upload_dir}/*"
145140
mv "launcher-config.yaml" "launcher-config-${cluster}.macos64.yaml"
146141
upload_artifacts "launcher-config-${cluster}.macos64.yaml"

scripts/with-nix-2.5.sh renamed to scripts/with-nix-unstable.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ fi
88

99
echo "~~~ Obtaining ‘pkgs.nixUnstable’"
1010

11-
myDir=$(dirname "$0")
12-
nixUnstable=$(nix-build "$myDir"/../default.nix -A pkgs.nixUnstable)
11+
# fe2ecaf706a5907b5e54d979fbde4924d84b65fc is nixos-unstable on 2023-04-13
12+
nixUnstable=$(nix-build https://github.com/NixOS/nixpkgs/archive/fe2ecaf706a5907b5e54d979fbde4924d84b65fc.tar.gz -A pkgs.nixUnstable)
1313

1414
PATH="$nixUnstable/bin:$PATH"
1515

0 commit comments

Comments
 (0)