Respect defaults in shellFor (fixes #2306)
#2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shellFor` has an argument `allToolDeps` that when set to `true` tells haskell.nix to include all the tool dependencies of all the packages in the shell. This does not work well for `stackProject` projects (since stackage includes a lot of packages). So it is disabled by default in `modules/stack-project.nix`.
This default is currently ignored if `shellFor` is called directly.
This change ensures that `shellFor` respects the defaults and any shell arguments passed to the project. As a result, `project.shell` and `project.shellFor {}` will now behave consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellForhas an argumentallToolDepsthat when set totruetells haskell.nix to include all the tool dependencies of all the packages in the shell. This does not work well forstackProjectprojects (since stackage includes a lot of packages). So it is disabled by default inmodules/stack-project.nix.This default is currently ignored if
shellForis called directly.This change ensures that
shellForrespects the defaults and any shell arguments passed to the project. As a result,project.shellandproject.shellFor {}will now behave consistently.