Fix workflow completion check and windows build issues#106
Merged
carbolymer merged 1 commit intomainfrom Nov 3, 2025
Merged
Conversation
carbolymer
changed the title
carbolymer
force-pushed
the
mgalazyn/make-gha-workflow-mandatory
branch
from
5528bb7 to
0f2f4e1
Compare
carbolymer
temporarily deployed
to
cabal-cache
GitHub Actions
Inactive
carbolymer
force-pushed
the
mgalazyn/make-gha-workflow-mandatory
branch
from
0f2f4e1 to
d2b1ad6
Compare
carbolymer
temporarily deployed
to
cabal-cache
GitHub Actions
Inactive
carbolymer
force-pushed
the
mgalazyn/make-gha-workflow-mandatory
branch
from
d2b1ad6 to
1b0ea3c
Compare
carbolymer
temporarily deployed
to
cabal-cache
GitHub Actions
Inactive
carbolymer
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR includes maintenance improvements: removing an unused import, adding documentation files to the cabal configuration, updating the changelog, and refactoring GitHub Actions workflows for better dependency tracking and merge queue support.
- Removed unused
System.Win32.Fileimport from NamedPipes module - Added extra-doc-files (CHANGELOG.md, README.md) to cabal configuration
- Refactored GitHub Actions workflow with new
build-successfuland renamedmake-tagjobs for better dependency management
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Hedgehog/Extras/Internal/Win32/NamedPipes.hsc | Removed unused System.Win32.File import |
| hedgehog-extras.cabal | Added CHANGELOG.md and README.md as extra-doc-files |
| CHANGELOG.md | Added entry for tar dependency update and fixed trailing newline |
| .github/workflows/haskell.yml | Added merge_group trigger, refactored check job to build-successful, renamed check to make-tag, improved conditional logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carbolymer
temporarily deployed
to
cabal-cache
GitHub Actions
Inactive
carbolymer
force-pushed
the
mgalazyn/make-gha-workflow-mandatory
branch
from
51a1f1a to
4324b53
Compare
carbolymer
temporarily deployed
to
cabal-cache
GitHub Actions
Inactive
Jimbo4350
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously GHA haskell workflow was letting in PRs failing CI builds. This PR splits the CI job
checkinto two:make-tag- incorrectly named previouslycheck- creates tagsbuild-successful- checks if all build jobs have succeeded