Expose process related functions without a MonadTest constraint#107
Open
Expose process related functions without a MonadTest constraint#107
MonadTest constraint#107Conversation
to utilize the Integration monad
the cleanUp action
Jimbo4350
requested review from
carbolymer and
newhoggy
and removed request for
carbolymer
carbolymer
reviewed
Nov 12, 2025
| -- * Re-exports of concurrency abstractions from @lifted-base@ | ||
| module Control.Concurrent.Async.Lifted, | ||
| module Control.Concurrent.MVar.Lifted, | ||
| module System.Timeout.Lifted, |
Contributor
There was a problem hiding this comment.
The formatting got changed here. Probably you've used fourmolu with default config and we're only using stylish in hedgehog-extrtas.
carbolymer
reviewed
Nov 12, 2025
| link a | ||
| return a | ||
| ) | ||
| cleanUp |
Contributor
There was a problem hiding this comment.
Suggested change
| cleanUp | |
| cancel |
that would be good enough I think
Contributor
|
Do you reckon we could add |
carbolymer
requested changes
Nov 12, 2025
Contributor
carbolymer
left a comment
carbolymer
left a comment
There was a problem hiding this comment.
Can you undo the formatting changes?
| procFlex = procFlex' defaultExecConfig | ||
|
|
||
|
|
||
| -- This will also catch async exceptions as well. |
Contributor
There was a problem hiding this comment.
Haddock for that function would be nice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cardano-testnethas some functions that are unnecessarily constrained withMonadTest. This PR aims to expose functionality to remove this restriction:See: IntersectMBO/cardano-node#6346