Make takeMVar exception safe #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Taking advantage of the jobs not cancelling on concurrency, we can see that this run fails: |
jasagredo
force-pushed
the
js/exception-takemvar
branch
from
49855e7 to
9ed29db
Compare
bolt12
reviewed
Oct 8, 2024
Contributor
bolt12
left a comment
bolt12
left a comment
There was a problem hiding this comment.
LGTM! Let's talk tomorrow at the networking meeting and I'll approve then
coot
reviewed
Oct 8, 2024
jasagredo
force-pushed
the
js/exception-takemvar
branch
from
9ed29db to
64d32ad
Compare
bolt12
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181