Skip to content

Conversation

@Saizan
Copy link
Contributor

@Saizan Saizan commented Nov 4, 2024

Using IntPSQ is much faster (20x) on some larger loads, and is recommended by psqueues where possible.

@bolt12
Copy link
Contributor

bolt12 commented Nov 4, 2024

Great! Could you make the changes for IOSimPOR too?

@Saizan
Copy link
Contributor Author

Saizan commented Nov 4, 2024

@bolt12 sure! Btw, is there something we could use to benchmark the runqueue field? We likely want to change that to HashPSQ.

@bolt12
Copy link
Contributor

bolt12 commented Nov 4, 2024

@bolt12 sure! Btw, is there something we could use to benchmark the runqueue field? We likely want to change that to HashPSQ.

I guess you can use https://github.com/IntersectMBO/ouroboros-network/blob/main/ouroboros-network/sim-tests-lib/Test/Ouroboros/Network/Testnet.hs#L121

@Saizan
Copy link
Contributor Author

Saizan commented Nov 4, 2024

The tests performance seem unaffected by the changes, probably not enough threads to make it relevant, but should likely help otherwise.

Also I had to add an orphan Hashable (Down a) instance, let me know if you'd prefer it to be moved or if you have other comments about coding style.

Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you !!

@bolt12 bolt12 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into input-output-hk:main with commit 785dc08 Nov 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants