-
Notifications
You must be signed in to change notification settings - Fork 22
Unique Symbol Generation #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions. A few minor comments.
Re the trace events, giving them the actual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can trace Integer
rather than IOSimUnique
, this will avoid the s
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @LSLeary, the PR looks good to me. Just some minor things. Please squash the commits and I'll merge it.
90b4802
to
2479e6b
Compare
The project I want to test with io-sim uses
Data.Unique
, so I wrote this.P.s. I'm not yet familiar with the library, let alone its internals—do let me know if I've written something silly.