Skip to content

fix: add full-width support to Select component #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix: add full-width support to Select component #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/design-system/select/select-root.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from 'react';

import ChevronDownIcon from '@icons/ChevronDownComponent';
import * as Select from '@radix-ui/react-select';
import cn from 'classnames';

import { Item, ItemRoot } from './select-item';
import * as cx from './select-root.component.css';
Expand All @@ -26,6 +27,8 @@ export type SelectRootProps = Pick<
portalContainer?: HTMLElement;
triggerTestId?: string;
zIndex?: number;
fullWidth?: boolean;
className?: string;
};

const isValidSelectRootChild = (
Expand Down Expand Up @@ -56,6 +59,8 @@ const isValidSelectRootChild = (
* @param variant The style variant.
* @param triggerTestId The `data-testid` attribute, passed to the input trigger / root element.
* @param zIndex The `z-index` applied to the `<Select.Content />`.
* @param fullWidth If `true`, the select trigger and content will take the full width of the parent container.
* @param className The CSS class name applied to the root element.
*/
export const Root = ({
align = 'selected',
Expand All @@ -73,6 +78,8 @@ export const Root = ({
variant = 'plain',
triggerTestId,
zIndex,
fullWidth = false,
className,
}: Readonly<SelectRootProps>): JSX.Element => {
const [isOpen, setIsOpen] = React.useState(defaultOpen);

Expand All @@ -87,9 +94,10 @@ export const Root = ({
onValueChange={onChange}
>
<Select.Trigger
className={cx.trigger[variant]}
id={id}
data-testid={triggerTestId}
className={cn(cx.trigger[variant], className)}
style={fullWidth ? { width: '100%' } : undefined}
>
<Select.Value placeholder={placeholder} />
{showArrow && (
Expand All @@ -100,7 +108,12 @@ export const Root = ({
</Select.Trigger>
<Select.Portal container={portalContainer}>
<Select.Content
style={{ zIndex }}
style={{
zIndex,
...(fullWidth
? { width: 'var(--radix-select-trigger-width)' }
: {}),
}}
className={cx.content[variant]}
position={align === 'selected' ? 'item-aligned' : 'popper'}
>
Expand Down
30 changes: 30 additions & 0 deletions src/design-system/select/select.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,34 @@ const SelectRootVariants = (): JSX.Element => {
);
};

const FullWidth = (): JSX.Element => (
<Section
title="Full width"
subtitle="The select stretches to fill its container."
>
<div style={{ width: '100%', marginBottom: '30px' }}>
<Select.Root
variant="outline"
align="bottom"
value={undefined}
onChange={(): void => void 0}
placeholder={placeholder}
showArrow
fullWidth
>
{options.map(option => (
<Select.Item
key={option.value}
value={option.value}
title={option.label}
disabled={option.disabled}
/>
))}
</Select.Root>
</div>
</Section>
);

export const Overview = (): JSX.Element => (
<Grid>
<Cell>
Expand All @@ -283,6 +311,8 @@ export const Overview = (): JSX.Element => (
<SelectVariants />
<Divider my="$64" />
<SelectRootVariants />
<Divider my="$64" />
<FullWidth />
</Cell>
</Grid>
);
Expand Down