fix: center eye icon in password input component [LW-10644] #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczeglik-iohk
approved these changes
Jul 24, 2024
DominikGuzei
force-pushed
the
fix/lw-10644-ui-create-wallet-name-and-password
branch
from
cf1d468 to
0614871
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
<PasswordBox>component required for https://input-output.atlassian.net/browse/LW-10644 where the "show/hide password" button icon is not correctly centered when used there:I have no idea how it could have been correctly aligned before (in Storybook it looks correct) since there are no styles for centering it, so it seems it was probably coincidence that it worked so far.
This is how it looks after this fix:
