chore: make profile dropdown more scalable [LW-10712] #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislavhoracek
changed the title
tomislavhoracek
changed the title
tomislavhoracek
force-pushed
the
chore/lw-10712-profile-dropdown-adjustments
branch
3 times, most recently
from
732cfdf to
fcb57d2
Compare
tomislavhoracek
requested review from
DominikGuzei,
mkazlauskas and
pczeglik-iohk
tomislavhoracek
commented
Aug 13, 2024
src/design-system/profile-dropdown/profile-dropdown-wallet-status.css.ts
Show resolved
Hide resolved
|
@tomislavhoracek please share some screenshots of the improvements you made 🙏 it's a bit hard to know what exactly you improved by just looking at the code |
|
For other reviewers, here is the chromatic storybook link to the component that was improved in the PR: https://6422dc516f0543c5fd174d4c-vlcriuqujt.chromatic.com/?path=/story/navigation-and-toolbars-profile-dropdown-trigger--overview |
tomislavhoracek
force-pushed
the
chore/lw-10712-profile-dropdown-adjustments
branch
from
81d7070 to
be50305
Compare
|
tomislavhoracek
deleted the
chore/lw-10712-profile-dropdown-adjustments
branch
pczeglik-iohk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces profile dropdown component adjustments so we can use them in a more scalable way and perform different variations.
Examples:
1. Profile Dropdown Trigger component
Story: https://6422dc516f0543c5fd174d4c-vlcriuqujt.chromatic.com/?path=/story/navigation-and-toolbars-profile-dropdown-trigger--overview
2. Profile Dropdown Wallet Status component
Story: https://6422dc516f0543c5fd174d4c-vlcriuqujt.chromatic.com/?path=/story/navigation-and-toolbars-profile-dropdown--overview