feat: allow custom components as profile dropdown profile image [LW-10712] #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislavhoracek
changed the title
tomislavhoracek
force-pushed
the
chore/lw-10712-use-custom-component-in-profile-dropdown
branch
from
19ddefc to
ae8e5eb
Compare
tomislavhoracek
changed the title
tomislavhoracek
force-pushed
the
chore/lw-10712-use-custom-component-in-profile-dropdown
branch
2 times, most recently
from
e86bea0 to
14edd50
Compare
tomislavhoracek
force-pushed
the
chore/lw-10712-use-custom-component-in-profile-dropdown
branch
from
14edd50 to
e2e3e1e
Compare
|
mkazlauskas
approved these changes
Aug 27, 2024
tomislavhoracek
deleted the
chore/lw-10712-use-custom-component-in-profile-dropdown
branch
pczeglik-iohk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a more robust way of loading images or even custom components ( with / without image ) to the profile dropdown root component and options component.
In this way we don't have to use base64 images to load them and it simplifies XSY code
Screenshots: