Skip to content

fix: box component now has a new property testId what will be rendered in the data-testid prop #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: box component now has a new property testId what will be rendered in the data-testid prop #50

merged 1 commit into from
Sep 11, 2024

Conversation

AngelCastilloB
Copy link
Member

Box component doesnt render data-testid on its inner div. This PR adds a new property testId to the Box component.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mkazlauskas
mkazlauskas approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@AngelCastilloB AngelCastilloB merged commit ab852ca into main Sep 11, 2024
3 checks passed
@AngelCastilloB AngelCastilloB deleted the fix/add-testId-property-to-box branch September 11, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelCastilloB @mkazlauskas