Feat/convert password box to uncontrolled component #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mchappell
commented
Nov 14, 2024
mchappell
commented
- Convert existing password box to a controlled component
- Remove the now unnecessary uncontrolledPasswordBox
- Listed conversion as breaking change because it will require prop updates when updating the lib as a dependency
mchappell
requested review from
szymonmaslowski,
przemyslaw-wlodek and
pczeglik-iohk
mchappell
force-pushed
the
feat/convert-password-box-to-uncontrolled-component
branch
from
5bffd4e to
effffb7
Compare
|
DominikGuzei
approved these changes
Nov 14, 2024
mchappell
deleted the
feat/convert-password-box-to-uncontrolled-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.