feat: make token amount details configurable [LW-11733] #65
Conversation
DominikGuzei
requested review from
greatertomi,
pczeglik-iohk and
przemyslaw-wlodek
and removed request for
greatertomi,
pczeglik-iohk and
przemyslaw-wlodek
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
pczeglik-iohk
left a comment
pczeglik-iohk
left a comment
There was a problem hiding this comment.
@DominikGuzei I think it should be marked as BREAKING CHANGE, as we are modifying api of this component.
pczeglik-iohk
left a comment
pczeglik-iohk
left a comment
There was a problem hiding this comment.
Would you be willing to improve this issue spot by CI
DominikGuzei
force-pushed
the
feat/lw-11733-configurable-token-amount-details
branch
3 times, most recently
from
aeb6a0a to
fa381d7
Compare
BREAKING CHANGE: TokenAmount props changed from a simple fiatPrice prop to a more flexible "details" prop which can further be customized by passing "detailsColor" and "detailsWeight" to cover more scenarios
DominikGuzei
force-pushed
the
feat/lw-11733-configurable-token-amount-details
branch
from
fa381d7 to
bfab9e7
Compare
|
|
@pczeglik-iohk ready for final review 🙏 |
pczeglik-iohk
left a comment
pczeglik-iohk
left a comment
There was a problem hiding this comment.
Code looks good. Thank you @DominikGuzei
pczeglik-iohk
deleted the
feat/lw-11733-configurable-token-amount-details
branch
This PR makes the
AssetTable.TokenAmountdetails more configurable (previously this was hardcoded forfiatPrice) so that its possible to apply any text color: