Skip to content

LW-13680 Add FF_OVERRIDE env variable to locally override feature flags #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LW-13680 Add FF_OVERRIDE env variable to locally override feature flags #2008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export class PostHogClient<Action extends string = string> {
hasPostHogInitialized$ = new BehaviorSubject(false);
featureFlagsByNetwork: FeatureFlagsByNetwork = featureFlagsByNetworkInitialValue;
featureFlagPayloads: FeatureFlagPayloads = featureFlagPayloadsInitialValue;
private ffOverride: Record<string, boolean> = {};

constructor(
private chain: Wallet.Cardano.ChainId,
Expand All @@ -66,6 +67,19 @@ export class PostHogClient<Action extends string = string> {
) {
if (!this.postHogHost) throw new Error('POSTHOG_HOST url has not been provided');
void this.initialize();

try {
const ffOverride = JSON.parse(process.env.FF_OVERRIDE) as Record<string, string | number>;

for (const [key, value] of Object.entries(ffOverride)) {
if (!['false', 'False', 'FALSE', '0', 0, 'true', 'True', 'TRUE', '1', 1].includes(value))
throw new Error(`Invalid value for FF_OVERRIDE[${key}]: "${value}"`);

this.ffOverride[key] = ['true', 'True', 'TRUE', '1', 1].includes(value);
}
} catch (error) {
commonLogger.error('While parsing FF_OVERRIDE', error);
}
}

private async initialize() {
Expand Down Expand Up @@ -224,6 +238,8 @@ export class PostHogClient<Action extends string = string> {
}

isFeatureFlagEnabled(feature: FeatureFlag): boolean {
if (feature in this.ffOverride) return this.ffOverride[feature];

const currentNetworkFeatureFlags =
this.featureFlagsByNetwork[this.chain.networkMagic as Wallet.Cardano.NetworkMagics];
return currentNetworkFeatureFlags[feature] || false;
Expand Down
Loading