fix(extension): add window focus change detection to lace tab activity check [LW-13679] #2010
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y check 1. The Service Worker (SW) exposes an observable isLaceTabActive$, which reports changes when: • a window is closed • a tab is updated (URL changes) • a tab is activated (user switches tabs) 2. The UI subscribes to this observable. 3. After ~30 seconds of inactivity, Chrome suspends the SW due to lack of focus. 4. When the UI resubscribes to isLaceTabActive$ after the SW was suspended: • The observable restarts with its startWith value (false). • Because the SW was suspended, no tab events (from step 1) have fired, so nothing updates the observable. • As a result, the UI keeps seeing false and shows “Blockchain out of sync.” 5. Returning to the tab does not fix the issue because no event is triggered to flip isLaceTabActive$ back to true. 6. Clicking the menus works because trigger navigation changes so the tab.onUpdated event fires, which updates isLaceTabActive$ to true. ⸻ Solution • The SW should also monitor the windowFocusChanged$ event. • When the window regains focus, the event will fire, the observable emits true if the tab is still open which tells the UI it is safe to resume communication.
|
mkazlauskas
approved these changes
Oct 6, 2025
Allure Report
processReports: ✅ test report for 904602e0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⸻
Solution
• The SW should also monitor the windowFocusChanged$ event.
• When the window regains focus, the event will fire, the observable
emits true if the tab is still open which tells the UI it is safe to resume communication.
Checklist
Proposed solution
Testing
Manual testing
Screenshots