refactor: replace "BFT nodes" with "Full nodes" in devnet

Author: dlachaume

docs/website/root/manual/getting-started/run-mithril-devnet.md

@@ -13,7 +13,7 @@ In this guide, you will learn how to run a demonstration of a **Mithril network*
 You can launch a private Mithril network using the following topology:
 
 * `2` **Cardano nodes** configured as **stake pool operators (SPOs)** with a **Mithril signer** on top
-* `1` **Cardano node** configured as a **BFT node** with a **Mithril aggregator** on top
+* `1` **Cardano node** configured as a **Full node** with a **Mithril aggregator** on top
 
 ![Devnet Topology](images/devnet-topology.png)
 
@@ -72,15 +72,15 @@ Open a terminal window. Run a devnet with one BTF and two SPO Cardano nodes.
 The network setup will be quicker when using remote Docker images:
 
 ```bash
-MITHRIL_IMAGE_ID=latest NUM_BFT_NODES=1 NUM_POOL_NODES=2 ./devnet-run.sh
+MITHRIL_IMAGE_ID=latest FULL_NODES=1 NUM_POOL_NODES=2 ./devnet-run.sh
 ```
 
 **Option 2**: Use local Docker images
 
 Note that using local Docker images to build Mithril nodes may take more time:
 
 ```bash
-NUM_BFT_NODES=1 NUM_POOL_NODES=2 ./devnet-run.sh
+FULL_NODES=1 NUM_POOL_NODES=2 ./devnet-run.sh
 ```
 
 :::info
@@ -101,9 +101,9 @@ You should see the following information displayed:
 =====================================================================
 
 >> Directory: artifacts
->> Cardano BFT nodes: 1
+>> Cardano Full nodes: 1
 >> Cardano SPO nodes: 2
->> Info: Mithril aggregator will be attached to the first Cardano BFT node
+>> Info: Mithril aggregator will be attached to the first Cardano Full node
 >> Info: Mithril signers will be attached to each Cardano SPO node
 
 =====================================================================
@@ -112,7 +112,7 @@ You should see the following information displayed:
 
 >> Start Cardano network
 cardano-node: no process found
->> Starting Cardano node 'node-bft1'
+>> Starting Cardano node 'node-full1'
 >> Starting Cardano node 'node-pool1'
 >> Starting Cardano node 'node-pool2'
 >> Wait for Cardano network to be ready
@@ -340,7 +340,7 @@ mithril-signer-node-pool2_1  | {"msg":"Sleeping for 1000","v":0,"name":"slog-rs"
 
 =====================================================================
 =====================================================================
-tail -n 22 ./node-bft1/node.log
+tail -n 22 ./node-full1/node.log
 =====================================================================
 [jp:cardano.node.ChainDB:Info:25] [2022-07-05 11:27:28.01 UTC] Took ledger snapshot DiskSnapshot {dsNumber = 219, dsSuffix = Nothing} at 075fc8366d353b45debedfc6faa92148c8fad584d81dbb4ea7b8b4d121489452 at slot 219
 [jp:cardano.node.ChainDB:Notice:21] [2022-07-05 11:27:40.76 UTC] Chain extended, new tip: af93c6964de49d0696bf194c222f6e5a40e5123ef688a20613a33a705b6b736a at slot 253

mithril-test-lab/mithril-devnet/README.md

@@ -4,9 +4,9 @@
 
 It scaffolds a private compound devnet with Cardano and Mithril nodes:
 
-* `N` Cardano BFT nodes
+* `N` Cardano Full nodes
 * `P` Cardano SPO nodes
-* `1` Mithril Aggregator node (attached to the first Cardano BFT node)
+* `1` Mithril Aggregator node (attached to the first Cardano Full node)
 * `P` Mithril Signer nodes (attached to each Cardano SPO nodes)
 
 ## Credits
@@ -34,10 +34,10 @@ chmod u+x *.sh
 ## One step run with default configuration
 
 ```bash
-# Run devnet with 1 BFT node and 2 SPO nodes (with local docker images)
+# Run devnet with 1 Full node and 2 SPO nodes (with local docker images)
 ./devnet-run.sh
 
-# Run devnet with 1 BFT node and 2 SPO nodes (with remote docker images)
+# Run devnet with 1 Full node and 2 SPO nodes (with remote docker images)
 MITHRIL_IMAGE_ID=main-c9213ca ./devnet-run.sh
 
 # Run devnet with Cardano nodes only
@@ -89,8 +89,8 @@ NODES=mithril ./devnet-query.sh
 ## One step run with custom configuration
 
 ```bash
-# Run devnet with 2 BFT nodes and 5 SPO nodes
-ARTIFACTS_DIR=artifacts NUM_BFT_NODES=2 NUM_POOL_NODES=5 ./devnet-run.sh
+# Run devnet with 2 Full nodes and 5 SPO nodes
+ARTIFACTS_DIR=artifacts NUM_FULL_NODES=2 NUM_POOL_NODES=5 ./devnet-run.sh
 
 # Run devnet custom slot length (0.5s) and custom epoch length (120s)
 # Slot length: the duration of a Cardano Eslot (can help modulate the immutables creation rate)
@@ -115,11 +115,11 @@ ARTIFACTS_DIR=artifacts ./devnet-visualize.sh
 ```bash
 # Parameters
 ARTIFACTS_DIR=artifacts # Directory where artifacts are produced
-NUM_BFT_NODES=1 # Number of Cardano BFT nodes
+NUM_FULL_NODES=1 # Number of Cardano Full nodes
 NUM_POOL_NODES=3 # Number of Cardano SPO nodes
 
-# Bootstrap devnet with 1 BFT nodes and 3 SPO nodes
-rm -rf ${ARTIFACTS_DIR} && ./devnet-mkfiles.sh ${ARTIFACTS_DIR} ${NUM_BFT_NODES} ${NUM_POOL_NODES}
+# Bootstrap devnet with 1 Full node and 3 SPO nodes
+rm -rf ${ARTIFACTS_DIR} && ./devnet-mkfiles.sh ${ARTIFACTS_DIR} ${NUM_FULL_NODES} ${NUM_POOL_NODES}
 
 # Change directory
 cd ${ARTIFACTS_DIR}
@@ -169,7 +169,7 @@ artifacts
 ├── cardano-node
 ├── docker-compose.yaml
 ├── log.sh
-├── node-bft1
+├── node-full1
 │   ├── byron
 │   │   ├── delegate.cert
 │   │   ├── delegate.key

mithril-test-lab/mithril-devnet/devnet-run.sh

@@ -43,7 +43,7 @@ fi
 
 # Start devnet Mithril nodes
 if [ "${NODES}" = "mithril" ] || [ "${NODES}" = "*" ]; then 
-    echo ">> Info: Mithril Aggregator will be attached to the first Cardano BFT node"
+    echo ">> Info: Mithril Aggregator will be attached to the first Cardano Full node"
     echo ">> Info: Mithril Signers will be attached to each Cardano SPO node"
     echo "====================================================================="
     echo " Start Mithril nodes"

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-docker.sh

@@ -10,7 +10,7 @@ version: "3.9"
 services:
 EOF
 
-for NODE in ${BFT_NODES}; do
+for NODE in ${FULL_NODES}; do
 
     PORT=$(cat ${NODE}/port)
     HOST=$(cat ${NODE}/host)
@@ -104,7 +104,7 @@ EOF
 
 done
 
-for NODE in ${BFT_NODES}; do
+for NODE in ${FULL_NODES}; do
 
 cat >> docker-compose.yaml <<EOF
   mithril-aggregator:

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-init.sh

@@ -29,8 +29,8 @@ fi
 if [ -z "${HARD_FORK_CONWAY_AT_EPOCH}" ]; then 
   HARD_FORK_CONWAY_AT_EPOCH=0
 fi
-if [ -z "${NUM_BFT_NODES}" ]; then 
-  NUM_BFT_NODES="1"
+if [ -z "${NUM_FULL_NODES}" ]; then 
+  NUM_FULL_NODES="1"
 fi
 if [ -z "${NUM_POOL_NODES}" ]; then 
   NUM_POOL_NODES="2"
@@ -49,7 +49,7 @@ DEVNET_VERSION=$(cat VERSION)
 # Display configuration summary
 echo ">> Devnet Version: ${DEVNET_VERSION}"
 echo ">> Artifacts Directory[env::ARTIFACTS_DIR]: ${ARTIFACTS_DIR}"
-echo ">> Cardano BFT nodes [env::NUM_BFT_NODES]: ${NUM_BFT_NODES}"
+echo ">> Cardano Full nodes [env::NUM_FULL_NODES]: ${NUM_FULL_NODES}"
 echo ">> Cardano SPO nodes [env::NUM_POOL_NODES]: ${NUM_POOL_NODES}"
 echo ">> Cardano Node Version [env::CARDANO_NODE_VERSION]: ${CARDANO_NODE_VERSION}"
 echo ">> Cardano Network Magic [env::NETWORK_MAGIC]: ${NETWORK_MAGIC}"

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-start.sh

@@ -12,7 +12,7 @@ set -e
 
 EOF
 
-for NODE in ${BFT_NODES}; do
+for NODE in ${FULL_NODES}; do
   cat >> ${NODE}/start-node.sh <<EOF
 #!/usr/bin/env bash
 

mithril-test-lab/mithril-devnet/mkfiles/mkfiles-topology.sh

@@ -2,15 +2,15 @@
 NODE_PORT_START=3000
 
 # Create network topology
-BFT_NODES=()
-BFT_NODES_N=()
-for (( i=1; i<=${NUM_BFT_NODES}; i++ ))
+FULL_NODES=()
+FULL_NODES_N=()
+for (( i=1; i<=${NUM_FULL_NODES}; i++ ))
   do
-    BFT_NODES=("${BFT_NODES[@]}" "node-bft${i}")
-    BFT_NODES_N=("${BFT_NODES_N[@]}" "${i}")
+    FULL_NODES=("${FULL_NODES[@]}" "node-full${i}")
+    FULL_NODES_N=("${FULL_NODES_N[@]}" "${i}")
 done
-BFT_NODES=${BFT_NODES[@]}
-BFT_NODES_N=${BFT_NODES_N[@]}
+FULL_NODES=${FULL_NODES[@]}
+FULL_NODES_N=${FULL_NODES_N[@]}
 
 POOL_NODES=()
 POOL_NODES_N=()
@@ -31,7 +31,7 @@ UTXO_ADDRS=${UTXO_ADDRS[@]}
 USER_ADDRS=${USER_ADDRS[@]}
 POOL_ADDRS=${POOL_ADDRS[@]}
 
-ALL_NODES="${BFT_NODES} ${POOL_NODES}"
+ALL_NODES="${FULL_NODES} ${POOL_NODES}"
 
 # create the node directories
 for NODE in ${ALL_NODES}; do
@@ -43,7 +43,7 @@ NODE_ADDR=$LISTENING_ADDR
 NODE_PORT=NODE_PORT_START
 TOPOLOGY='{"Producers": []}'
 TOPOLOGY_DOCKER=$TOPOLOGY
-for NODE in ${BFT_NODES}; do
+for NODE in ${FULL_NODES}; do
   NODE_PORT=$(( ${NODE_PORT} + 1))
   echo ${NODE_PORT} > ${NODE}/port
   echo ${LISTENING_ADDR} > ${NODE}/host
@@ -56,7 +56,7 @@ for NODE in ${POOL_NODES}; do
 done
 echo $TOPOLOGY | jq . > topology.json
 
-for NODE in ${BFT_NODES}; do
+for NODE in ${FULL_NODES}; do
   cat topology.json > ${NODE}/topology.json
 done
 NODE_IX=0

mithril-test-lab/mithril-end-to-end/src/devnet/runner.rs

@@ -86,7 +86,7 @@ impl Devnet {
             "ARTIFACTS_DIR",
             bootstrap_args.artifacts_target_dir.to_str().unwrap(),
         );
-        bootstrap_command.env("NUM_BFT_NODES", 0.to_string());
+        bootstrap_command.env("NUM_FULL_NODES", 0.to_string());
         bootstrap_command.env(
             "NUM_POOL_NODES",
             bootstrap_args.number_of_pool_nodes.to_string(),