feat: make allow_unparsable_block configurable on Aggregator node

Add 'allow_unparsable_block' clap argument and Configuration parameter.

Author: dlachaume

mithril-aggregator/src/commands/serve_command.rs

@@ -36,6 +36,12 @@ pub struct ServeCommand {
     /// Will be ignored if set in conjunction with `--disable-digests-cache`.
     #[clap(long)]
     reset_digests_cache: bool,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on production networks.
+    #[clap(long)]
+    allow_unparsable_block: bool,
 }
 
 impl Source for ServeCommand {

mithril-aggregator/src/configuration.rs

@@ -147,6 +147,11 @@ pub struct Configuration {
 
     /// Time interval at which the signers in [Self::cexplorer_pools_url] will be imported (in minutes).
     pub signer_importer_run_interval: u64,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on production networks.
+    pub allow_unparsable_block: bool,
 }
 
 /// Uploader needed to copy the snapshot once computed.
@@ -218,6 +223,7 @@ impl Configuration {
             zstandard_parameters: Some(ZstandardCompressionParameters::default()),
             cexplorer_pools_url: None,
             signer_importer_run_interval: 1,
+            allow_unparsable_block: false,
         }
     }
 
@@ -348,6 +354,11 @@ pub struct DefaultConfiguration {
 
     /// Signer importer run interval default setting
     pub signer_importer_run_interval: u64,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on production networks.
+    pub allow_unparsable_block: String,
 }
 
 impl Default for DefaultConfiguration {
@@ -367,6 +378,7 @@ impl Default for DefaultConfiguration {
             snapshot_compression_algorithm: "zstandard".to_string(),
             snapshot_use_cdn_domain: "false".to_string(),
             signer_importer_run_interval: 720,
+            allow_unparsable_block: "false".to_string(),
         }
     }
 }
@@ -465,6 +477,13 @@ impl Source for DefaultConfiguration {
                 ValueKind::from(myself.signer_importer_run_interval),
             ),
         );
+        result.insert(
+            "allow_unparsable_block".to_string(),
+            Value::new(
+                Some(&namespace),
+                ValueKind::from(myself.allow_unparsable_block),
+            ),
+        );
 
         Ok(result)
     }

mithril-aggregator/src/dependency_injection/builder.rs

@@ -714,10 +714,12 @@ impl DependenciesBuilder {
     }
 
     async fn build_transaction_parser(&mut self) -> Result<Arc<dyn TransactionParser>> {
-        // TODO: 'allow_unparsable_block' parameter should be configurable
-        let allow_unparsable_block = false;
-        let transaction_parser =
-            CardanoTransactionParser::new(self.get_logger().await?, allow_unparsable_block);
+        let transaction_parser = CardanoTransactionParser::new(
+            self.get_logger().await?,
+            self.configuration
+                .get_network()?
+                .allow_unparsable_block(self.configuration.allow_unparsable_block)?,
+        );
 
         Ok(Arc::new(transaction_parser))
     }