Skip to content

Integrate ALBA and STM #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Integrate ALBA and STM #2709

wants to merge 1 commit into from

Conversation

curiecrypt
Copy link
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2025
View reviewed changes
mithril-stm/src/aggregate_signature/telescope_stm/mod.rs
Comment on lines +25 to +26
let stakes = (0..NPARTIES)
.into_iter()

Check warning

Code scanning / clippy

useless conversion to the same type: std::ops::Range<usize> Warning

useless conversion to the same type: std::ops::Range<usize>
mithril-stm/src/aggregate_signature/telescope_stm/mod.rs

println!("Signers created");

let sig = ps[0].sign(&msg).unwrap();

Check warning

Code scanning / clippy

this expression creates a reference which is immediately dereferenced by the compiler Warning

this expression creates a reference which is immediately dereferenced by the compiler
mithril-stm/src/aggregate_signature/telescope_stm/telescope_clerk.rs
Comment on lines +166 to +172
if let Some(unique_index) = self.lottery_hash_index_map.get(e.as_ref()) {
if let Some(signer_index) = e.index {
proof_index_sequence.push((*unique_index, signer_index));
valid_signer_indexes.insert(signer_index);
valid_indices.insert(*unique_index);
}
}

Check warning

Code scanning / clippy

this if statement can be collapsed Warning

this if statement can be collapsed
mithril-stm/src/aggregate_signature/telescope_stm/telescope_clerk.rs
Comment on lines +166 to +172
if let Some(unique_index) = self.lottery_hash_index_map.get(e.as_ref()) {
if let Some(signer_index) = e.index {
proof_index_sequence.push((*unique_index, signer_index));
valid_signer_indexes.insert(signer_index);
valid_indices.insert(*unique_index);
}
}

Check warning

Code scanning / clippy

this if statement can be collapsed Warning

this if statement can be collapsed
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0    164 suites  ±0   23m 47s ⏱️ -2s
2 183 tests +1  2 182 ✅ ±0  0 💤 ±0  1 ❌ +1 
6 712 runs  +3  6 711 ✅ +2  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 84b3374. ± Comparison against base commit 0df5853.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@curiecrypt