-
Notifications
You must be signed in to change notification settings - Fork 52
feat: simple aggregator discovery #2779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpraynaud
wants to merge
21
commits into
main
Choose a base branch
from
jpraynaud/2726-simple-aggregator-discovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,411
−48
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
97111bc
chore(aggregator-discovery): scaffold new crate
jpraynaud 3be68f4
feat(aggregator-discovery): add models for aggregator endpoint
jpraynaud 166c031
feat(aggregator-discovery): introduce 'AggregatorDiscoverer' trait
jpraynaud 9ab4d58
feat(aggregator-discovery): create test double for 'AggregatorDiscove…
jpraynaud a34afed
feat(aggregator-discovery): add 'HttpConfigAggregatorDiscoverer'
jpraynaud 76e6ab7
refactor(aggregator-discovery): 'AggregatorDiscoverer' returns an ite…
jpraynaud 09dfc38
feat(aggregator-discovery): add 'ShuffleAggregatorDiscoverer' decorator
jpraynaud 353e9e3
wip(aggregator-discovery): add 'CapableAggregatorDiscoverer' decorator
jpraynaud 6a3ecca
fix(aggregator-discovery): 'CapableAggregatorDiscovererIterator' impl…
jpraynaud 6ee5693
test(aggregator-discovery): add tests for 'CapableAggregatorDiscovere…
jpraynaud 30d4d5d
refactor(client): prepare client builder for aggregator discovery
jpraynaud b7b9eed
fix(aggregator-discovery): remove unneeded 'crate-type' in 'Cargo.toml'
jpraynaud 4681baa
refactor(aggregator-discovery): remove the 'rand' feature
jpraynaud 857d931
feat(client): implement basic aggregator discoverer
jpraynaud 2273b77
feat(aggregator-discovery): implement aggregator discovery in client …
jpraynaud 55a5843
feat(aggregator-discovery): add HTTP timeouts
jpraynaud 8b19110
refactor(aggregator-discoverer): introduce 'RequiredAggregatorCapabil…
jpraynaud 426aa37
chore(client): re-export missing types from common
jpraynaud 6b35ce4
chore(client): update capabilities to required capabilities
jpraynaud c55e43b
wip(client-cli)
jpraynaud c9f8423
wip(client-cli): new aggregator discovery command
jpraynaud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,38 @@ | ||||||
| [package] | ||||||
| name = "mithril-aggregator-discovery" | ||||||
| description = "Mechanisms to discover aggregator available in a Mithril network." | ||||||
|
||||||
| description = "Mechanisms to discover aggregator available in a Mithril network." | |
| description = "Mechanisms to discover aggregators available in a Mithril network." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .PHONY: all build test check doc | ||
|
|
||
| CARGO = cargo | ||
|
|
||
| all: test build | ||
|
|
||
| build: | ||
| ${CARGO} build --release | ||
|
|
||
| test: | ||
| ${CARGO} test | ||
|
|
||
| check: | ||
| ${CARGO} check --release --all-features --all-targets | ||
| ${CARGO} clippy --release --all-features --all-targets | ||
| ${CARGO} fmt --check | ||
|
|
||
| doc: | ||
| ${CARGO} doc --no-deps --open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Mithril-aggregator-discovery | ||
|
|
||
| This crate provides mechanisms to discover aggregators in a Mithril network. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected grammar: 'aggregator' should be 'aggregators'.