feat(stm): Lottery target value computation for snark proof #2958
+448
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comments and trait implementations
change log and crates version
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rebased on its parent
curiecrypt
force-pushed
the
curiecrypt/msnark/phase1-target-value
branch
from
e2e6a9e to
1160cc5
Compare
Test Results 4 files - 1 169 suites - 3 23m 42s ⏱️ - 8m 17s Results for commit 1160cc5. ± Comparison against base commit 376235c. This pull request removes 105 and adds 1 tests. Note that renamed tests count towards both. |
rrtoledo
reviewed
Jan 27, 2026
| let w = Float::with_val(117, stake) / Float::with_val(117, total_stake); | ||
| let phi = Float::with_val(117, 1.0) - Float::with_val(117, 1.0 - phi_f).pow(w); | ||
| // increase precision | ||
| let phi_high = Float::with_val(300, phi); |
Collaborator
There was a problem hiding this comment.
Can phi_high really have a precision of 300 if phi has a precision of 100 (I do not know how this work)?
Collaborator
There was a problem hiding this comment.
Just checked, and float (such as f64) should be deterministic, not sure about Float though.
rrtoledo
reviewed
Jan 27, 2026
| ) -> StmResult<LotteryTargetValue> { | ||
| // modulus - 1 | ||
| let ev_max = -BaseFieldElement::get_one(); | ||
| if !(0.0..=1.0).contains(&phi_f) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes lottery target value computation for snark proof system.
Pre-submit checklist
Comments
A new sub-module
lotteryis added underprotocolmodule.lotteryonly includes thesnark_eligibility. Eligibility check for concatenation proof will be moved to this sub-module later.Issue(s)
Relates to #2792