fix(stm): Fix the implementation difference for schnorr signature between cpu and circuit #2994
+114
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the implementation of the unique schnorr signature that differs between cpu and circuit. This fix mainly consists in modifying the input to the
signandverifyfunctions of theunique_schnorr_signaturemodule to takeBaseFieldElements instead of arbitrary bytes. The bytes that were previously handled within the sign function will be treated outside of the signature in a later PR.Warning: This PR does not include the proper handling of the message bytes and merkle root before giving them to the signature function!
Content of the PR:
hash_to_projective_pointto haveBaseFieldElementas inputssignandverifyfunctions to take&[BaseFieldElement]instead of&[u8]BaseFieldElementto the benchesFrom<&[u8;32]>implementation toBaseFieldElementfor testing onlyPre-submit checklist
Comments
Issue(s)
Relates to #2993