fix(stm): Fix the implementation difference for schnorr signature between cpu and circuit #2994
+114
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chnorr and updated the tests
damrobi
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
damrobi
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
hjeljeli32
approved these changes
Feb 11, 2026
Collaborator
hjeljeli32
left a comment
hjeljeli32
left a comment
There was a problem hiding this comment.
@damrobi
Thanks a lot for the quick turnaround on this PR 🙏
This looks really good to me and is fully aligned with the decisions we discussed yesterday.
I left a couple of small comments regarding doc comments that are now slightly outdated, but nothing blocking from my side.
Great work 👍
| @@ -63,18 +62,10 @@ impl ProjectivePoint { | |||
| /// Hashes input bytes to a projective point on the Jubjub curve | |||
Collaborator
There was a problem hiding this comment.
@damrobi
The doc comment on hash_to_projective_point is now outdated.
| /// and works with the Jubjub elliptic curve and the Poseidon hash function. | ||
| /// | ||
| /// Input: | ||
| /// - a message: some bytes |
| /// | ||
| /// Input: | ||
| /// - a Unique Schnorr signature | ||
| /// - a message: some bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the implementation of the unique schnorr signature that differs between cpu and circuit. This fix mainly consists in modifying the input to the
signandverifyfunctions of theunique_schnorr_signaturemodule to takeBaseFieldElements instead of arbitrary bytes. The bytes that were previously handled within the sign function will be treated outside of the signature in a later PR.Warning: This PR does not include the proper handling of the message bytes and merkle root before giving them to the signature function!
Content of the PR:
hash_to_projective_pointto haveBaseFieldElementas inputssignandverifyfunctions to take&[BaseFieldElement]instead of&[u8]BaseFieldElementto the benchesFrom<&[u8;32]>implementation toBaseFieldElementfor testing onlyPre-submit checklist
Comments
Issue(s)
Relates to #2993